Lodash: Remove completely from @wordpress/edit-widgets package
#43682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
sgomes,
aristath,
gziolo,
swissspidy,
jorgefilipecosta,
chad1008,
ntsekouras and
fabiankaegy
tyxla
requested review from
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel and
kevin940726
as code owners
sgomes
approved these changes
Aug 29, 2022
| @@ -14,7 +9,7 @@ const { Fill: ToolsMoreMenuGroup, Slot } = createSlotFill( | |||
|
|
|||
| ToolsMoreMenuGroup.Slot = ( { fillProps } ) => ( | |||
| <Slot fillProps={ fillProps }> | |||
| { ( fills ) => ! isEmpty( fills ) && fills } | |||
| { ( fills ) => fills.length > 0 && fills } | |||
There was a problem hiding this comment.
Thanks for double-checking, but nope, it's always an array:
gutenberg/packages/components/src/slot-fill/slot.js
Lines 70 to 92 in b33b256
There was a problem hiding this comment.
Well, then I don't understand why we needed the second fills here 😅? It probably would be safe also to delete it.
There was a problem hiding this comment.
Well, then I don't understand why we needed the second
fillshere 😅? It probably would be safe also to delete it.
I left it as-is, but I can open a follow-up PR if you feel strongly about it 😅
|
Size Change: +1 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all of the Lodash occurrences from the
@wordpress/edit-widgetspackage, and Lodash as a dependency altogether.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495While this PR doesn't affect bundle size at all (because this package's code is not bundled), it still is a step forward in the direction of completely getting rid of Lodash in Gutenberg.
How?
We're replacing every Lodash call with native functionality.
Testing Instructions
ToolsMoreMenuGroupstill works well, register a few fills there (there are none by default).