Replace the OPTIONS requests with a faster HEAD request in canUser resolver #43703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
|
Size Change: +4 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
The CI run reveals a lot of these errors:
Therefore, a support for HEAD requests would have to be first added to the endpoints before it can be added to |
|
I can confirm that an |
9 tasks
|
@adamziel I'd love to get this merged or something like it as it will fix the inability to retrieve Navigation permissions by slug. What do we need to do? Fix the tests? I'm happy to try to do that. |
getdave
force-pushed
the
use-head-requests-for-permissions
branch
from
ef30c45 to
73ed3c1
Compare
I also tested this and using the editor I can see permissions API requests coming back with This might be test specific as suggested by @TimothyBJacobs. A quick search for |
|
I'm getting |
|
Sorry, bit of a brainfart from me. Those endpoints would have a |
|
While the REST API server does handle |
|
Thinking about this some more, it seems like we don't have to use Which ever resource method they use, we need permissions requests to:
Is there a way we could patch (or even use a filter for) |
|
Not entirely related, but I think |
|
We can check the headers of a 403 response as follows: wp.apiFetch({
path: '/wp/v2/templates',
method: 'HEAD',
parse: false
})
.catch(response => response.headers.get('date'))
.then(console.log)Which means
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
The https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/rest-api.php#L815
Agreed. I don't think this is much of an issue. |
adamziel
added
the
[Status] Blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TimothyBJacobs noted:
This PR is an attempt at just switching the http method to see if the CI checks will pass.
At the moment, this PR is blocked as the HEAD method won't work for all relevant requests, see https://core.trac.wordpress.org/ticket/56481 for more details