Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scaffold.js #43740

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Update scaffold.js #43740

merged 1 commit into from
Aug 31, 2022

Conversation

jonathanbossenger
Copy link
Contributor

Minor string "bug" fix

What?

Adding a space in the success message when generating a block-only block

Why?

Because otherwise it looks like this:

Done: Block "No Plugin" bootstrapped in the wp-block-namedirectory

How?

Adding the space

Testing Instructions

  1. Run npx @wordpress/create-block --no-plugin
  2. Follow the prompts, and inspect the success message once the code is scaffolded.

Minor string "bug" fix
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix 👍🏻

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jonathanbossenger! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 31, 2022
@gziolo gziolo added [Tool] Create Block /packages/create-block [Type] Code Quality Issues or PRs that relate to code quality labels Aug 31, 2022
@gziolo gziolo merged commit bdb6a41 into WordPress:trunk Aug 31, 2022
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Tool] Create Block /packages/create-block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants