Editor: Simplify 'findOrCreateTerm' method logic #43766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
2 tasks
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
fullofcaffeine
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #40850.
PR updates the
findOrCreateTermmethod and removes additional API call for searching existing term. The search request could fail when matches exceed the hardcoded limit and using unbound queries for search can have performance costs.Updated logic:
error.code !== 'term_exists', we return rejected promise with that error.term_exists. Error response already containsterm_id; we use this to return resolved promise.Testing Instructions
TypeError: Cannot read properties of undefined (reading name)error.term_existserror.Screenshots or screencast
CleanShot.2022-09-01.at.13.49.07.mp4