ToggleGroupControl: Decouple borderless style with icon use #43771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
Thank you. Some of the precise usage is likely going to continue to evolve a little bit as we update the inspectors across all blocks (still a lot of work to do), so it seems fine to keep the docs and props up to date as we stabilize 🙏 |
ciampo
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Code changes LGTM.
I'm not particularly a fan of prop names that very descriptive rather than semantic, but I understand that this may be a temporary change while we assess how the border vs borderless solutions feel like.
Personally, I'd vote for always showing borders and getting rid of the borderless prop, as I believe that borderless togglegroups can look a bit confusing to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
__experimentalIsIconGroupto__experimentalIsBorderless.Why?
We're seeing use cases of icon button toggles that are not using the borderless style (#37930, #43674). After confirming with @jasmussen that this is intentional, we've decided to remove any documentation suggesting that icon button toggles should use the borderless style. This should keep our docs truthful until a clearer style guide is established down the line.
Testing Instructions
npm run storybook:dev