Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON syntax issues in theme.json examples. #43828

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

mrobit
Copy link
Contributor

@mrobit mrobit commented Sep 2, 2022

What?

This PR fixes two trailing commas in the JSON examples for the theme.json documentation. Pretty lame PR, but figured this couldn't hurt!

Why?

It's minor, but if anyone copies and pastes these examples, they'll have a JSON syntax issue.

How?

Deleting the trailing commas.

Fixed a couple trailing commas.
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mrobit! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@fabiankaegy fabiankaegy merged commit c703ff0 into WordPress:trunk Sep 5, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Congratulations on your first merged pull request, @mrobit! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Sep 5, 2022
@fabiankaegy
Copy link
Member

Thanks for your contribution @mrobit 🚀

@cbravobernal cbravobernal added the Needs User Documentation Needs new user documentation label Sep 13, 2022
@bph bph added [Type] Developer Documentation Documentation for developers and removed Needs User Documentation Needs new user documentation labels Sep 14, 2022
@bph
Copy link
Contributor

bph commented Sep 14, 2022

Label [Type] User Documentation is for change concering End users = Content creators and no-code site builder

The [Type] Developer Documentation is the label used for the plugin release to automattically create the changelog section "Documentation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants