-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Playwright #43887
Merged
Merged
Update Playwright #43887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
kevin940726 and
gziolo
and removed request for
kevin940726
September 6, 2022 06:01
Mamaduka
added
the
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
label
Sep 6, 2022
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
That's cool, I was wondering whether that was possible earlier 🎉 |
talldan
approved these changes
Sep 6, 2022
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade
@playwright/test
to v1.25.1.The recent changelog can be found here - https://github.com/microsoft/playwright/releases?page=1.
Why?
The primary motivation is the new
--trace=on
flag. It allows enabling a trace for any test.We often get cases when tests fail on CI but are passing locally. This flag will allow us to compare failing and successful test runs, which can help identify the issue.
Testing Instructions
CI should pass.