Docs: fix required status of onSelectUrl
prop of MediaReplaceFlow
component
#44025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix documaentation of the
MediaReplaceFlow
component to indicate that theonSelectUrl
prop is not actually required.Looking at the sourcecode the code checks for the presence of the prop and only renders the media url field if the callback function was provided.
gutenberg/packages/block-editor/src/components/media-replace-flow/index.js
Lines 207 to 228 in 6465552
Why?
Because the current documentation is misleading