Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a broken link to the format-api example #44058

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

kkoppenhaver
Copy link
Contributor

What?

As identified in WordPress/Documentation-Issue-Tracker#408, there was a broken link on the Formatting Toolbar API page.

Why?

The link taking users to the gutenberg-examples repo should actually take them to the correct location instead of 404ing.

How?

Updates an outdated GitHub link with the current working link.

Testing Instructions

  1. Load the documentation page for the Formatting Toolbar API.
  2. Follow the link at the very bottom of the page that prompts users to "Download the format-api example from the gutenberg-examples repository."
  3. See that the updated URL for this link directs users to the correct portion of the GitHub repo.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 11, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kkoppenhaver! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Copy link
Member

@amustaque97 amustaque97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Changes look good to me. 🚀

@amustaque97 amustaque97 added the [Type] Developer Documentation Documentation for developers label Sep 11, 2022
@talldan
Copy link
Contributor

talldan commented Sep 12, 2022

There are failing tests, but they were fixed by #44052, so I'll move ahead with merging.

@talldan talldan merged commit f849152 into WordPress:trunk Sep 12, 2022
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Sep 12, 2022
@kkoppenhaver kkoppenhaver deleted the fix/broken-format-api-link branch September 12, 2022 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants