Try: Improve partial selections. #44154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -7 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jasmussen
requested review from
a team and
gwwar
and removed request for
a team
mtias
added
the
[Feature] Writing Flow
priethor
added
the
Backport to WP 6.7 Beta/RC
|
Wanted to note that even with this applied, there still appears to be some flickering happening when selecting inside the list block, where it seems to be shifting between partial and multiselection at a rapid pace: |
mtias
added
the
[Priority] High
|
This may seem fine, but now we no longer show the outline if blocks are fully selected. To reproduce, create two paragraphs and then press Cmd+A twice:
|
|
I'll see if we can avoid returning true for that selector when in between blocks. |
|
Trying something in #44230. |
|
Closing in favor of #44230. |
ockham
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #44153.
This PR needs a double check, as I'm touching code I don't fully understand. You can consider it a proof of concept.
By removing
__unstableIsFullySelectedfrom the criteria of whenis-partially-selectedis applied, the text selection behavior appears to be less flickery and stable when moving from paragraph to paragraph, and into an image:It isn't entirely clear what
__unstableIsFullySelecteddoes to me, so this needs a look.