-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Use start without watcher using --no-watch #44237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this PR. The change proposed makes sense 👍🏻
There are some formatting issues and running npm run format
will fix them.
50e7d48
to
4cc05a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an entry in the Changelog file. I need to test it locally before merging to trunk
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2076d6a
to
40d45c7
Compare
Sorry for the delay, fixed now. It's ready to be merged now |
Thank you for addressing my feedback. I will land it as soon as I have a chance to test it again. |
@gziolo could you please check and merge this now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well with the changes applied. Thank you so much.
What?
Sometimes there's a use case, where we don't want to use "npm start" with the watcher.
Why?
"npm start" directly followed by Ctrl+C, or certain CI environments that want to create unminified JS for analysis without changing the config,...
How?
Testing Instructions
any gutenberg, isntead of "npm start" run "npm start -- --no-watch", which will create the unminified/dev JS without starting the watcher.