-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E tests: update button selector #45087
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
ramonjd
added
[Type] Build Tooling
Issues or PRs related to build tooling
[Package] E2E Tests
/packages/e2e-tests
labels
Oct 18, 2022
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
ramonjd
force-pushed
the
update/e2e-button-selector-preview
branch
from
October 19, 2022 02:00
234575b
to
874bca8
Compare
andrewserong
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix looks legit to me! Assuming they pass, let's merge 😄
ramonjd
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Oct 19, 2022
ockham
pushed a commit
that referenced
this pull request
Oct 25, 2022
* Update E2E test after Post editor: Rename view to Preview (#45074) * Follow ups * Mucho linto
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 8e9a664 |
ockham
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Oct 25, 2022
This was referenced Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] E2E Tests
/packages/e2e-tests
[Type] Bug
An existing feature does not function as intended
[Type] Build Tooling
Issues or PRs related to build tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update E2E selector after the change in #45074
Why?
A button label "View" was changed to "Preview"
How?
By typing.
Testing Instructions
E2E tests should 🟢