Site Editor: Move the save view state to the edit site store #45200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
16 tasks
|
Size Change: +302 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Oct 21, 2022
youknowriad
commented
Oct 21, 2022
ntsekouras
reviewed
Oct 21, 2022
|
This is a nice cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #44770
What?
Instead of using local state for the save view state, we move this to the edit site store.
Why?
This allows us to allow unnecessary props passing top down, which is also great to make our components more reusable.
How?
Just did the same thing we do for list view state.
Testing Instructions
Make some changes in the site editor and save them.