[Pattern Setup]: Fix full heights during transition. #46615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +16 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #46381
This comment shows at least a couple of issues to be handled. One is handled in this PR and is visible when we have different heights of patterns next to each other in
carouselmode, some content overlaps during the transition. The second one is that we use css transition of0.5sand if we click the pagination buttons too quickly can feel shaky and bad. For the second problem I'll explore even changing the implementation to use css like scroll-snap.Testing Instructions
Choosecarouselmode go to a pattern with big height that is next to a smaller height one and click next and previousTesting Instructions for Keyboard
Before
Screen.Recording.2022-12-16.at.2.44.59.PM.mov
After
Screen.Recording.2022-12-16.at.2.46.08.PM.mov