Optimize keydown event handlers #46653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
perf/micro-optimize-keydown-event-handlers
branch
from
07ac595 to
e270b1d
Compare
youknowriad
requested review from
jorgefilipecosta and
aaronjorbin
and removed request for
aaronjorbin
jorgefilipecosta
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and Why
In my measurements, keydown events represent 10% of the "typing" metric approximatively so that's 5ms out of 50ms. I noticed that we have a dozen of keydown event handlers in our code base, This PR micro-optimizes a couple of them to bail early when possible.
To be honest I don't expect any impact on the numbers maybe 1ms (which is within the margin of error) but it's also a harmless PR.