Fix inspector tab active state border #46686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
the
[Feature] Inspector Controls
|
Size Change: +18 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
| @@ -41,6 +41,7 @@ | |||
| } | |||
|
|
|||
| .block-editor-block-inspector__tab-item { | |||
| bottom: -1px; | |||
There was a problem hiding this comment.
Would it make sense to use -$border-width instead of the hardcoded -1px? ($border-width=1px).
|
Closed for #48945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The active border-bottom treatment to the
.block-editor-block-inspector__tab-itemin the new tabbed Styles/Settings UI is slightly off. That's because the elements surrounding the tabs typically have a border-bottom applied, whereas these tabs do not — instead each.components-pane__bodyelement has a border-top.Why?
To ensure consistency across all tabbed UX patterns.
How?
Minor style change.
Testing Instructions
Screenshots or screencast
Before:
After:
Notice the Page/Block and Style/Settings tabs look the same now.