[Inserter]: Hide empty pattern categories #46923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +23 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f9d289a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3854010158
|
youknowriad
reviewed
Jan 6, 2023
youknowriad
approved these changes
Jan 6, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Right now we show all the available pattern categories without checking if there are available allowed patterns for the specific
rootClientIdwe want to insert them.This PR shows only the pattern categories we have pattern to suggest.
Testing Instructions
innerBlockthrough the Insertersocial iconsblock) and only that pattern category is shown.Before
before.mov
After
after.mov