ColorPalette: Show checkered background through semi-transparent colors #47476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
added
[Type] Enhancement
|
Size Change: +32 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
brookewp
force-pushed
the
update/colorpalette-background
branch
from
98d0642 to
d36ff24
Compare
Ah, this makes sense! So outside of the swatch, like the below example?
(But of course getting design involved to make the design on how it looks) |
That could definitely be one way!
Yup! Next steps could be:
What do you think about this plan? |
Sounds great! Thank you! |
priethor
added
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix #42715
This PR addresses the above issue for
ColorPalette, to make it possible to see the color being selected regardless of the set transparency.This change also highlights an existing issue where when transparency is adjusted, the text becomes inaccessible due to low contrast.
In the below screencasts, 'what it should look like' is based on the solution proposed here: #47373, which isn't included in this PR. Therefore, there's another screencast to show how the change in this PR differs from that and the current state in trunk.
Why?
To improve the UX by showing a preview of the selected color value regardless of transparency.
How?
By adding a class to the parent component and moving the background styles onto that so it is behind the selected custom color.
Testing Instructions
Screenshots or screencast '
Screen.Recording.2023-01-26.at.4.mp4
Screen.Recording.2023-01-26.at.4.2.mp4
Screen.Recording.2023-01-26.at.4.1.mp4