Visual Regression tests: use default playwright utils #47991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Bug
t-hamano
approved these changes
Feb 11, 2023
ciampo
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 13, 2023
* Visual Regression tests: use default playwright utils instead of custom wordpress utils * Add new snapshot dir to gitignore
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 80aaf64 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #47988
Use PlayWright default
testandexpectutils for Visual Regression tests running on Storybook stories.Why?
This fixes an issue introduced by #46459, where Visual Regression tests would timeout indefinitely. This is caused by the fact that utils from the
'@wordpress/e2e-test-utils-playwright'package would assume that the e2e would load the editor.How?
Since Visual Regression test don't seem to need any of the additions introduced by
'@wordpress/e2e-test-utils-playwright', switching to the default versions from PlayWright seems the correct fix.Testing Instructions
npm run distclean && npm ciIn two separate tabs:
npm run storybook:e2e:devnpm run test:e2e:storybook -- --update-snapshotsMake sure that tests don't time out
Make sure that the generated snapshot images are gitignored