[Editor]: Select blocks in outline list
#48118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +16 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 66b66e5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4202719754
|
ellatrix
reviewed
Feb 16, 2023
| onSelect={ onSelect } | ||
| onSelect={ () => { | ||
| selectBlock( item.clientId ); | ||
| onSelect?.(); |
There was a problem hiding this comment.
This this used to work because of the link to the anchor. I wonder if we can trigger a URL change in the iframe...
|
Thank you for the PR! I'm wondering if this link should be a button rather than an anchor to begin with. Because in the non-iframe editor, the selected block is not centered, perhaps because the anchor link takes precedence: 2dd93dc66c3ddd38538325d8983ff639.mp4As follows, I would expect the selected block to be centered, iframe editor or not: 03c95edc1f8cc9fe59c3bf6a03f2bca5.mp4Anchor links were initially implemented in #10815 with the expectation that the content would be in the same document. However, now that we cannot guarantee that the content exists in the same document, we might be able to revert to buttons. |
ellatrix
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Looks good. There's a potential alternative solution with the target attribute which could open the link in a specific iframe (editor-canvas), but it doesn't work well out of the box because there's no initial URL, so it refreshes the page. So I think this is the best solution.
Should the href links be removed and be converted into buttons? Fine either way for me.
ntsekouras
force-pushed
the
fix/outline-select-items
branch
from
d5a672a to
66b66e5
Compare
@t-hamano let's discuss and do this in a follow up, as the current change fixes the iframed case and matches the non iframed one. What do you think? |
t-hamano
approved these changes
Feb 17, 2023
Sounds good, let's do that 👍 However, what about backporting this PR to WordPress 6.2? |
This needs no back port since the editor will not be iframed in core. |
ntsekouras
force-pushed
the
fix/outline-select-items
branch
from
66b66e5 to
a293977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #47624
The heading links in the post outline no longer work. This is a problem when the post editor is iframed. This PR fixes that by also selecting the block.
The main issue has a few things to resolve regarding the Post Title. Right now it's not shown for iframed editor and the link is not working in non iframed editor.
Testing Instructions
Before
before.mp4
After
after.mp4