Rich text: only selectively handle keyup/pointerup #48385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +158 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d16ec3e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4261721487
|
ellatrix
force-pushed
the
try/rich-text-remove-keyup
branch
from
e6cffa5 to
0381c93
Compare
ellatrix
changed the title
ellatrix
added
[Type] Performance
youknowriad
reviewed
Feb 24, 2023
|
|
||
| function onUp() { | ||
| onCancel(); | ||
| ownerDocument.dispatchEvent( new Event( 'selectionchange' ) ); |
There was a problem hiding this comment.
What happens when the "selection" doesn't change, should we guard against it?
There was a problem hiding this comment.
Updated it. While I don't see an improvement in performance, we're still reducing the amount of times createRecord is called and I like this isolated polyfill approach making it clearer what is happening.
youknowriad
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Sometimes some browsers are not firing a
selectionchangeevent when changing the selection by mouse or keyboard. This hook makes sure that, if we detect noselectionchangeorinputevent between the up and down events, we fire aselectionchangeevent.Why?
Performance
How?
Testing Instructions
E2e tests should pass.
Testing Instructions for Keyboard
Screenshots or screencast