Site Editor: update the edit button #48584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
Size Change: -981 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c28933d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4292610071
|
|
Happy to try this, looks good. Occasionally the edit icon will look top heavy, but it's actually correctly centered:
I do wonder, however, if we should use the new edit-small icon here instead?
Nothing blocking, but curious of your thoughts, @jameskoster @SaxonF |
jasmussen
approved these changes
Feb 28, 2023
I think it looks top heavy because the icon itself has (imo) some peculiar dimensions. Particularly the pencil peeking outside of the 16px square. I don't have a strong preference on either. This obviously veers into component territory, but the blue hover looks a bit awkward to me, and the icon disappears entirely on click:
I don't think we've quite nailed down the design for these buttons in the dark material just yet. So for now perhaps it would be best to align with the Back button? |
|
Ok, with the last commit, all these buttons are actually using the same component with the same styles, so we can change them in a unique place. |
jameskoster
approved these changes
Feb 28, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: aa903d5 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the design of the "edit" button in the site editor sidebar. Now that you can click the canvas to edit, the "primary" edit button was a bit too prominent.
I'm using the same style, we're using for the "plus" icon to add templates in the "templates" sidebar.