Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds anchor block support to List Items #48758

Merged

Conversation

tomdevisser
Copy link
Member

Adds anchor block support to List Items, in it's block.json, and updated the docs accordingly. This couldn't be done before, as the List Item wasn't a child block back then.

Fixes #29838

@tomdevisser tomdevisser requested a review from mtias March 5, 2023 12:01
@tomdevisser tomdevisser self-assigned this Mar 5, 2023
@tomdevisser tomdevisser added the [Type] Enhancement A suggestion for improvement. label Mar 5, 2023
@skorasaurus skorasaurus added the [Block] List Affects the List Block label Aug 18, 2023
@ejnwebmaster
Copy link

I'm new this, but this seems so close to being complete. Is there a way to bring this to closure? I appreciate the hard work by all, truly.

Copy link

github-actions bot commented Feb 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tomdevisser <[email protected]>
Co-authored-by: ejnwebmaster <[email protected]>
Co-authored-by: mtias <[email protected]>
Co-authored-by: adamwoodnz <[email protected]>
Co-authored-by: pbiron <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@talldan talldan force-pushed the update/add-anchor-to-list-item branch from 704e49a to 0f7c5d2 Compare August 7, 2024 03:11
@talldan talldan requested a review from ndiego as a code owner August 7, 2024 03:11
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased the PR and it's still working well for me. Thanks for the contribution!

@talldan talldan merged commit 9a55d5f into WordPress:trunk Aug 7, 2024
60 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI for setting ID (anchors) on list items (<li>)
4 participants