-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rootTagsToEliminate prop from native Rich Text component #48983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Mobile App - Automation
Label used to initiate Mobile App PR Automation
labels
Mar 10, 2023
derekblank
changed the title
Remove rootTagsToEliminate prop from Rich Text
Remove rootTagsToEliminate prop from native Rich Text component
Mar 10, 2023
Size Change: -8 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
dcalhoun
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking down this now unnecessary code. I performed the testing instructions and the manual Writing Flow tests on an iPhone SE. I did not observe any issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - Automation
Label used to initiate Mobile App PR Automation
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes a four-year-old temporary workaround from Aztec within the native Rich Text component.
Why?
This prop is no longer used, and can be removed as part of an overall effort to reduce the complexity of the native Rich Text file to improve performance.
How?
Removed the prop
rootTagsToEliminate
from the Rich Text component, and associated references from the File and Caption blocks.Testing Instructions
<p>
tag.<p>
tag.Testing Instructions for Keyboard
This change does not affect the user interface.