Fix: Global Styles getPresetsClasses crashes if no selector is passed. #49024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
Size Change: +5 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 49961cb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4405048464
|
jorgefilipecosta
deleted the
fix/global-styles-getPresetsClasses-crashes-if-there-is-no-selector-passed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the creation of a "story" for the full global styles UI, we don't have the base WordPress style objects and I noticed a series of crashes. All the global styles code should work even if we don't have a base styles object.
This fix is part of the series of fixes.
It avoids a crash in cases where getPresetsClasses is called without a selector that may happen because the selectors' metadata object may not be present.