-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Add viewport optional props #49696
Conversation
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
Flaky tests detected in a2439da. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4660200504
|
@@ -98,7 +98,6 @@ const observeAndResizeJS = ` | |||
// get an DOM mutations for that, so do the resize when the window is resized, too. | |||
window.addEventListener( 'resize', sendResize, true ); | |||
window.addEventListener( 'orientationchange', sendResize, true ); | |||
widow.addEventListener( 'click', sendResize, true ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #49663 (comment)
@@ -215,7 +215,7 @@ function Sandbox( { | |||
<title>{ title }</title> | |||
<meta | |||
name="viewport" | |||
content="width=device-width, initial-scale=1" | |||
content={ `width=device-width, initial-scale=1, ${ viewportProps }` } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that an extra comma is fine in the case where someone prefixes viewportProps
with a comma like ", user-scalable=0"
What?
Adds a the
viewportProps
prop to theSandbox
component.Why?
There are cases where the owner of a
Sandbox
needs to control the html viewport.How?
Adds a prop to the
Sandbox
that is added to the default viewport settings.Testing Instructions
Verify the change does not introduce any regression issues.
Feature testing is TBD
Testing Instructions for Keyboard
Screenshots or screencast