Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Callout documentation on links #50131

Merged
merged 6 commits into from
Apr 28, 2023
Merged

Docs: Update Callout documentation on links #50131

merged 6 commits into from
Apr 28, 2023

Conversation

bph
Copy link
Contributor

@bph bph commented Apr 27, 2023

What?

Fixes #50125

  • Add note to use HTML links in callouts
  • relative links for the block -editor handbook
  • fixed links in previous docs update

Why?

The link parser only works in Markdown links.

How?

for now: hard-coding relative links to work in the block editor handbook.

Testing Instructions

Needs to be merged before it can be tested.

@bph bph self-assigned this Apr 27, 2023
@bph bph added the [Type] Developer Documentation Documentation for developers label Apr 27, 2023
@bph bph marked this pull request as ready for review April 27, 2023 13:26
@bph bph requested a review from gziolo April 27, 2023 13:28
@bph bph requested a review from gziolo April 27, 2023 14:16
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try and see if that resolves the issue for good 😄

It looks good to me.

@bph bph merged commit 3c88c64 into trunk Apr 28, 2023
@bph bph deleted the docs/callout-links branch April 28, 2023 08:07
@github-actions github-actions bot added this to the Gutenberg 15.8 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Add instructions to use HTML links inside callouts
2 participants