Navigation: Move the ALLOWED_BLOCKS const to a shared location #50323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
In theory, could this be filterable to allow third-party extenders to add their own blocks to Navigation blocks? |
|
Size Change: -14 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
It could break things but that would be up to the extender to guard against. Either way I think it should be a different PR :) |
|
Yeah, definitely a separate PR, I was just curious if this would be the correct "thing" to filter if we ever wanted to allow that functionality. |
Not sure if we want to open that box 😅 Maybe an Related discussion #15682. |
|
Sorry but this appears to be a partial duplicate of #50191. Can we normalize towards that early PR? |
|
Closing in favour of #50191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Creates a new shared file to store the list of ALLOWED_BLOCKS inside the Navigation block
Why?
So that they can't get out of sync.
Testing Instructions
Check that the navigation block is still limited to the blocks inside ALLOWED_BLOCKS.