Block Editor: Directly import useShouldContextualToolbarShow hook #50506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
Mamaduka
commented
May 10, 2023
|
|
||
| function selector( select ) { | ||
| const { | ||
| __unstableGetEditorMode, | ||
| hasMultiSelection, | ||
| isTyping, | ||
| getLastMultiSelectedBlockClientId, | ||
| } = unlock( select( blockEditorStore ) ); | ||
| } = select( blockEditorStore ); |
There was a problem hiding this comment.
The mapSelect no longer uses private selectors.
|
Size Change: +2.91 kB (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d3f8dd8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4937122050
|
ntsekouras
approved these changes
May 10, 2023
Mamaduka
force-pushed
the
update/contextual-toolbar-hook-import
branch
from
c1a4f63 to
d3f8dd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #49644.
PR removes unnecessary unlocking of private APIs from the
SelectedBlockPopovercomponent.Why?
The file is in the same package as a hook. So there's no need for it to use unlocking API.
Testing Instructions