Browse mode Navigation: Fix broken submenu items #50551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
added
[Feature] List View
MaggieCabrera
requested review from
jorgefilipecosta,
scruffian,
draganescu,
getdave,
jeryj and
ajlende
|
Size Change: +8 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
jeryj
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #50536
Why?
The current experience is broken and it shows half of the nav block that should be hidden in specific edge cases
How?
We hide the hidden block properly, this time using the
VisuallyHiddencomponent. We need to be mindful that we don't undo the work from #48746 and the related link control popovers are still showingTesting Instructions
Screenshots or screencast