Fix Link UI showing on mount for first and last nav menu items #50638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +32 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
scruffian
force-pushed
the
use/list-view-in-inspector
branch
from
74a8ac2 to
774ffe0
Compare
scruffian
force-pushed
the
use/list-view-in-inspector
branch
from
cd8f581 to
f61c627
Compare
draganescu
force-pushed
the
use/list-view-in-inspector
branch
from
02564c5 to
c23b638
Compare
Added a isMounted ref to not check if the link ui should show for the lastInsertedBlock, as there's no way a block could have been added on mount.
jeryj
force-pushed
the
fix/link-ui-opens-on-mount
branch
from
1a79aa8 to
fe881da
Compare
jeryj
changed the title
|
Flaky tests detected in fe881da. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5005092371
|
getdave
requested changes
May 19, 2023
There was a problem hiding this comment.
Thank you for working on a fix here.
I've raised a blocking review because I don't think we should be relying on this pattern to achieve the fix.
The "mounted" thing tends to be used when we're obscuring an underlying problem that's more deeply embedded. In this case that's exactly what I think we're doing. More information on the issue here.
I will spin up a PR shortly with an alternative route.
|
Closing this in favour of #50774. |
auto-merge was automatically disabled
May 19, 2023 12:15
Pull request was closed
It was absolutely used as a workaround for a more underlying problem. Thanks for raising a different PR to address it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50601
What?
Prevents the Link Control UI from showing for empty custom links when the sidebar List View is mounted.
Why?
If you have a custom link without a URL in the first or last spot on your navigation menu, every time the sidebar list view is mounted, the Link Control will show unexpectedly.
How?
There wasn't a way I could find to identify if a block had just been inserted, as on mount the
lastInsertedBlockIdwas set to the first item in the existing navigation menu. We know the Link UI should never show when it's first mounted, so I added aisMountedref that gets set totrueafter the firstuseEffecthook is run. This ensures the Link UI won't display on mount.Testing Instructions
Test Setup
Link UI Should not show on mount when the LAST item doesn't have a link
Link UI Should not show on mount when the FIRST item doesn't have a link
Link UI Should Show When Adding a Link
Screenshots or screencast