Template pattern modal: remove internal modal classnames #50655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mirka and @ntsekouras , let me know if this solution looks good to you. It would be interesting to understand if we can adopt a similar approach for #50595, it would probably be the best solution IMO. In case this approach doesn't cut it, here are some alternatives that we could consider:
What do you think? |
ciampo
added
[Package] Components
ciampo
commented
May 16, 2023
| .components-modal__content { | ||
| padding-bottom: 0; | ||
| } | ||
| $actions-height: 92px; |
There was a problem hiding this comment.
The main way the resulting layout is achieved in this PR is:
- by making the actions bar absolute positioned, so that it's always stuck at the bottom of the modal
- by using a fixed
height(instead of padding top/bottom) to resize the actions bar - by using that same height as extra padding bottom in the modal content, to preserve correct overflow scroll behaviour
|
Size Change: -31 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 207fddd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4989596964
|
ntsekouras
reviewed
May 16, 2023
There was a problem hiding this comment.
Thanks for the PR Marco! The end results seems the same to me. I'd defer to @jameskoster for a sanity check though.
jameskoster
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes references to private, internal
Modalclass names from the Template pattern modal, achieving the same desired layout without them.Follow-up from #50099 (comment)
Why?
Class names should not be regarded as public APIs of a component, and therefore should not be used outside of that component's internal implementation.
Using class names this way can really quickly lead to poor CSS architecture, making it impossible to achieve good modularity, composition, and style encapsulation.
How?
Modalclass namesModalclass namesTesting Instructions
start blankoption in template pattern suggestions and addskipbutton #50099)Screenshots or screencast