Add SelectControl to change post-template markup. #50694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
changed the title
|
Size Change: +117 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
torounit
force-pushed
the
add/post-template-markup-selector
branch
3 times, most recently
from
2bff695 to
968fbc0
Compare
torounit
force-pushed
the
add/post-template-markup-selector
branch
from
968fbc0 to
657dd25
Compare
torounit
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
@aristath Pull Request is ready. Can you review it? |
fabiankaegy
added
Needs Accessibility Feedback
torounit
changed the title
torounit
force-pushed
the
add/post-template-markup-selector
branch
from
5f830c6 to
26724dd
Compare
|
Flaky tests detected in f20db86. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5247974188
|
torounit
changed the title
torounit
force-pushed
the
add/post-template-markup-selector
branch
from
f20db86 to
9553ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a SelectControl to change Post Template markup to
ulordiv.Why?
fix #50627. #37659 will also be fixed IMO.
How?
Add
SelectControlfor change markup to Post Template block. The default value is ul > li for markup. This can now be changed to div > div.Also changed so that styles like
.column-3 > liare applied to elements that are notli.Testing Instructions
Screenshots or screencast
2023-08-24.23.50.17.mov