Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - E2E test - Update code to use the new navigateUp helper #50736

Merged
merged 4 commits into from
May 18, 2023
Merged

Mobile - E2E test - Update code to use the new navigateUp helper #50736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5422105
Mobile - E2E test - Update code to use the new navigateUp helper
May 18, 2023
c00d254
Mobile - E2E helpers - Update navigateUp helper to include recursive …
May 18, 2023
273a819
Mobile - E2E Helpers - Rename navigateUp to moveBlockSelectionUp with…
May 18, 2023
36e627f
Mobile - E2E test - Update usage of navigateUp to new moveBlockSelect…
May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/react-native-editor/__device-tests__/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,7 @@ onlyOniOS( 'Gutenberg Editor Cover Block test', () => {
expect( coverBlock ).toBeTruthy();

// Navigate upwards to select parent block
const navigateUpElement =
await editorPage.waitForElementToBeDisplayedById( 'Navigate Up' );
await navigateUpElement.click();
await editorPage.moveBlockSelectionUp();
await editorPage.removeBlockAtPosition( blockNames.cover );
} );

Expand All @@ -150,9 +148,7 @@ onlyOniOS( 'Gutenberg Editor Cover Block test', () => {
);
await coverBlock.click();
// Navigate upwards to select parent block
const navigateUpElement =
await editorPage.waitForElementToBeDisplayedById( 'Navigate Up' );
await navigateUpElement.click();
await editorPage.moveBlockSelectionUp();

await editorPage.openBlockSettings();
await editorPage.clickAddMediaFromCoverBlock();
Expand Down
5 changes: 4 additions & 1 deletion packages/react-native-editor/__device-tests__/pages/editor-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ class EditorPage {
await toolBarButton.click();
}

async navigateUp() {
async moveBlockSelectionUp( options = { toRoot: false } ) {
let navigateUpElements = [];
do {
await this.driver.sleep( 2000 );
Expand All @@ -509,6 +509,9 @@ class EditorPage {
if ( navigateUpElements.length > 0 ) {
await navigateUpElements[ 0 ].click();
}
if ( ! options.toRoot ) {
break;
}
} while ( navigateUpElements.length > 0 );
}

Expand Down