-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Toolbar: Fix text only label for locked blocks #50944
Conversation
&:focus::before { | ||
right: $grid-unit-10 !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Size Change: +7 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also considered that, but since it wasn't applied to the drag handle, I thought we wanted separation for text labels. @joedolson suggested using "Unlock" for the label. I was thinking of a separate PR, but happy to handle that here.
The whole block toolbar styling needs refactoring to accommodate the current buttons. But, as you know, it's filled with hacks and workarounds. @carolinan, I don't like that either. I'll try to fix it, but CSS for the block-locking button is hacky enough and don't want to introduce more 😓 Screenshots |
Flaky tests detected in 204bddc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5129012394
|
@jasmussen, @carolinan, let me know if I can address any more feedback. |
feee8d5
to
204bddc
Compare
The label is updated now (#51083), and PR is ready for another round of tests. |
204bddc
to
f30362b
Compare
I just cherry-picked this PR to the release/16.0 branch to get it included in the next release: 7294485 |
What?
Fixes #49865.
PR adjusts the styling of the text-only label for locked blocks.
Testing Instructions
Screenshots or screencast