Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md on SlotFills to add info + example about the prop fillProps #51013

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

rmorse
Copy link
Contributor

@rmorse rmorse commented May 26, 2023

Add info and example about fillProps prop on Slot

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Add info and example about `fillProps` prop on `Slot`
@rmorse rmorse requested a review from ajitbohra as a code owner May 26, 2023 14:44
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label May 26, 2023
@Mamaduka Mamaduka requested review from ryanwelcher and mburridge May 27, 2023 06:40
@ndiego ndiego self-requested a review May 31, 2023 13:48
packages/components/src/slot-fill/README.md Outdated Show resolved Hide resolved
packages/components/src/slot-fill/README.md Outdated Show resolved Hide resolved
@ndiego
Copy link
Member

ndiego commented May 31, 2023

Thanks @rmorse, this looks great. Just a few minor tweaks.

@rmorse
Copy link
Contributor Author

rmorse commented Jun 1, 2023

Good catch @ndiego - commited the changes, thanks!

Copy link
Contributor

@mburridge mburridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndiego ndiego merged commit dca6a9c into WordPress:trunk Jun 1, 2023
@github-actions github-actions bot added this to the Gutenberg 16.0 milestone Jun 1, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
…illProps` (WordPress#51013)

* Update README.md

Add info and example about `fillProps` prop on `Slot`

* Update packages/components/src/slot-fill/README.md

Co-authored-by: Nick Diego <[email protected]>

* Update packages/components/src/slot-fill/README.md

Co-authored-by: Nick Diego <[email protected]>

---------

Co-authored-by: Nick Diego <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants