Lightbox UI appearing with interactivity experiment disabled #51025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Bug
cbravobernal
requested review from
spacedmonkey,
kevin940726 and
ellatrix
as code owners
cbravobernal
force-pushed
the
fix/disable-behaviors-without-experimental
branch
2 times, most recently
from
429e289 to
b33d064
Compare
cbravobernal
force-pushed
the
fix/disable-behaviors-without-experimental
branch
from
b33d064 to
775543c
Compare
cbravobernal
changed the title
cbravobernal
added
the
Backport to Gutenberg RC
|
Size Change: +23 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in db6c878. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5095560839
|
talldan
approved these changes
May 29, 2023
SantosGuillamot
approved these changes
May 29, 2023
|
Cherry picked for Gutenberg 15.9 RC2 |
cbravobernal
added a commit
that referenced
this pull request
May 29, 2023
* Fix lightbox ui appearing with interactivity experiment disabled * Update e2e tests to enable the experiment
cbravobernal
removed
the
Backport to Gutenberg RC
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…ss#51025) * Fix lightbox ui appearing with interactivity experiment disabled * Update e2e tests to enable the experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A Lightbox feature for images has been recently merged into Gutenberg for the 15.9. This feature can be enabled with a dropdown on advanced settings of the Image block. As it requires the Interactivity API, it only works if you have the experiment enabled.
Lightbox option:
Experiments required to be enabled:
Right now, the Behavior UI interface appears even when the experiment is disabled. As we have only one behavior, and requires the Interactivity API to be enabled, it shouldn't be like that. This PR fixes.
How?
Hiding the behaviors UI if the Interactivity API is disabled.
Testing Instructions