Disable Lightbox UI if link has an image #51180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
requested review from
Mamaduka,
jasmussen,
artemiomorales and
SantosGuillamot
|
Size Change: +57 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
artemiomorales
approved these changes
Jun 2, 2023
SantosGuillamot
approved these changes
Jun 2, 2023
artemiomorales
pushed a commit
to artemiomorales/gutenberg
that referenced
this pull request
Jun 2, 2023
cbravobernal
added
[Block] Image
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #51127
Why?
Right now, if an image has a link attached, if the user interacts with it, it will go to that link. For that reason, we could not be able to apply the Lightbox feature.
As @jasmussen mentioned:
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Lightbox enabled in an image without a link
Lightbox disabled in an image with a link
