Rename 'page content lock' to 'page content focus' #51280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Code Quality
noisysocks
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: +6 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f6ff0a1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5195166410
|
andrewserong
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Nice improvement @noisysocks! PageContentFocus feels better to me than PageContentLock, too, as it's clearer that it's talking about the post content having focus 👍
✅ Editing content in page content focus mode works as on trunk
✅ Switching between template editing mode and page content mode works as on trunk
✅ Renaming looks good and consistent
I agree it would've been good to somehow have a more generic word than page or post for flexibility, but I think the current naming is still good and clear, and I doubt it'll cause too much confusion.
So long as this makes it into Gutenberg 16.0 we don't need to do deprecations.
It looks like the 16.0 RC 1 has already been pushed, so once this PR lands, it'll need to be cherry picked to the release branch.
LGTM! ✨
noisysocks
added
the
Backport to Gutenberg RC
|
Can you please include this in 16.0 @ndiego? 🙏 |
fullofcaffeine
pushed a commit
that referenced
this pull request
Jun 9, 2023
ndiego
removed
the
Backport to Gutenberg RC
noisysocks
added
the
[Feature] Page Content Focus
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Renames all the new APIs added in #50857 from 'page content lock' to 'page content focus'.
Why?
I don't want to use the word "lock" since this feature no longer has anything to do with
templateLock(it used to).I did want to move away from "page" towards "post" as that matches the general convention in WordPress that everything is a "post", but, on second thought, I don't think we should do this because
@wordpress/edit-sitealready has the stablesetPageselector which I think we should align with.How?
Find and replace. So long as this makes it into Gutenberg 16.0 we don't need to do deprecations.
Testing Instructions
Same as in #50857.