-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove anchor support from dynamic blocks #51288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This PR contains changes to PHP files, but a similar PR has already been merged into the |
add this attribute manually because of this Gutenberg's change WordPress/gutenberg#51288
* Remove anchor support from dynamic blocks * Remove unnecessary codes
Fixes: #48232
Fixes: #49382
Fixes: #49578
Related to: #48438
What?
This PR reverts anchor support for dynamic blocks added by #44771.
Why?
In #44771, anchor support was added to dynamic blocks, but static blocks with existing anchor were broken (See #48232, #49382, and #49578). This feature was originally planned to be included in WordPress 6.2, but #48232 was the first to report this issue during the Beta phase. Therefore, by #48592, this feature was excluded in the WordPress 6.2 release.
However, this feature still remains on the Gutenberg plugin, which will be bundled with WordPress 6.3 and will cause similar problems. A solution was attempted in #48438, but we decided to revert anchor support for dynamic blocks in the Gutenberg plugin as well, in order to find a more ideal solution.
How?
Strikes out the changes made in #44771 as is, removing anchor support for a total of 53 dynamic blocks. After #44771 was merged, a new Time To Read block was added. However, this block does not currently support anchor, so it does not need to be considered in this PR.
Testing Instructions
trunk
branch, insert all types of blocks as follows: