Categories: Add a list style type option to the categories block #51344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
scruffian
commented
Jun 8, 2023
| }, | ||
| "listStyleType": { | ||
| "type": "string", | ||
| "default": "inherit" |
There was a problem hiding this comment.
I'm not sure if the default should just be an empty string.
|
Size Change: +121 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in aad17d9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5286920217
|
|
You got me thinking about language-specific types and whether we could let GlotPress translators opt in to one extra type of their choice. It might look like this: /**
* translators: If your language uses a specific numeral system supported by
* the CSS property 'list-style-type', you may enter its code here. Examples
* include 'armenian', 'trad-chinese-informal', 'kannada'. Otherwise, enter
* 'lower-roman' to opt in to lowercase Roman numerals. Do not translate into
* your own language.
*/
const extraStyleTypeValue = _x( 'lower-roman', 'List item style type. Do not translate!' );
/**
* translators: For context, see string 'lower-roman' with the context 'List
* item style type'. If you have entered a custom value to replace the use of
* lowercase Roman numerals with a numbering system that better suits your
* language, please enter its name here translated into your language.
* Otherwise, enter a direct translation of "Roman numerals". For example,
* "Numeração romana" if you have chosen Roman numerals and are translating
* into Portuguese.
*/
const extraStyleTypeLabel = _x( 'Roman numerals', 'List item style description' );
if ( extraStyleTypeValue && extraStyleTypeLabel ) {
options.push( {
value: extraStyleTypeValue,
label: extraStyleTypeLabel,
} );
}Now, if we were to introduce this, it might be a general editor value and not just applicable to the Categories block. /cc @akirk who might be interested in this :) |
|
Btw, I based my suggestion on this precedent: gutenberg/packages/block-library/src/post-excerpt/edit.js Lines 79 to 84 in 625b2de |
pbking
force-pushed
the
add/categories-list-type
branch
from
afb916a to
3838305
Compare
|
I fixed a minor conflict and addressed the yoda expression the linting complained about. This tested out fine for me. |
|
Could we make the list block and the categories list match better? In the list block, the option to choose between ol and ul is in the toolbar, and there are only style options for the ol. In the category block, there are only style options for the ul, this is confusing. |
|
Yeah, it'd be nice to align the experience of lists and its featureset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds a list style type attribute to the categories list block.
Why?
The current block isn't customizable, so it's not possible to change the discs without CSS. This is quite a strong opinion, so it would be good if themes could use the block without needing to use this style.
How?
Adds a
listStyleTypeattribute to the categories block.Testing Instructions
Screenshots or screencast