[RNMobile] Ensure dictating text doesn't cause cursor to be offset on iOS #51528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
added
[Focus] Accessibility (a11y)
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
SiobhyB
force-pushed
the
rnmobile/fix/dictation-cursor-position
branch
3 times, most recently
from
d6dc6f6 to
35316ba
Compare
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
… iOS (WordPress#51528) The changes in this PR ensure that the cursor's position is always correct during dictation on iOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51227
Related PRs
gutenberg-mobile: [RNMobile] Ensure dictating text doesn't cause cursor to be offset on iOS wordpress-mobile/gutenberg-mobile#5868WordPress-iOS: TESTING ONLY: Ensure dictating text doesn't cause cursor to be offset on iOS wordpress-mobile/WordPress-iOS#20881What?
The changes in this PR ensure that the cursor's position is always correct during dictation on iOS.
Why?
While dictating text in the editor on iOS, there are currently some occasions where the cursor's position is either off-by-one, or when it briefly appears out of place on a new line. It'd be preferable for the cursor to always remain in the correct position.
How?
This PR introduces a
newPositionOffsetvariable that captures whether the cursor's position is off-by-one. If it is, one is subtracted to ensure the cursor is always at the correct position.Testing Instructions