Unify welcome guides labels casing #51700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Package] Edit Site
|
Size Change: +10 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 34712f5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5322908578
|
apeatling
approved these changes
Jun 20, 2023
|
Looks good to me 👍 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There are five welcome guides currently in use: two in the post editor, two in the site editor, and one the widgets editor.
In these welcome guides, the 'Get started' button text uses inconsistent casing:
Welcome to Stylesvs.Welcome to styleswhere the letter s of styles uses inconsistent casing. While one of these strings is not visible (because it is used for an aria-label attribute), it still produces two different strings to translate on translate.wordpress.orgThe two 'Get started' strings on translate.wordpress.org:
The two 'Welcome to styles' strings on translate.wordpress.org:
Why?
Test should use consistent casing. Avoid title case where appropriate.
We should make translators life as comfortable as possible.
How?
Testing Instructions
wp_persisted_preferencesuser meta and change all the values of the welcome guides tob:1;Testing Instructions for Keyboard
Screenshots or screencast