fix: Display heading level dropdown icons and labels #52004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent refactor for web was only partially applied to the sibling native files. This finishes the application so that the active selection is displayed, passed through via the `value` prop.
Without using Icon, the SVG elements rendered without a width, causing layout issues and invisible icons.
dcalhoun
added
[Type] Regression
dcalhoun
commented
Jun 28, 2023
packages/block-editor/src/components/block-heading-level-dropdown/heading-level-icon.js
Show resolved
Hide resolved
|
Size Change: +3 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
carolinan
reviewed
Jun 28, 2023
| controls={ HEADING_LEVELS.map( ( index ) => | ||
| createLevelControl( index, selectedLevel, onChange ) | ||
| icon={ <HeadingLevelIcon level={ value } /> } | ||
| controls={ options.map( ( index ) => |
There was a problem hiding this comment.
This is embarrassing, thank you.
geriux
approved these changes
Jun 28, 2023
|
Flaky tests detected in d79e92b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5396932202
|
dcalhoun
added a commit
that referenced
this pull request
Jun 29, 2023
* fix: Heading level dropdown displays active selection A recent refactor for web was only partially applied to the sibling native files. This finishes the application so that the active selection is displayed, passed through via the `value` prop. * fix: Heading level dropdown leverages Icon Without using Icon, the SVG elements rendered without a width, causing layout issues and invisible icons.
4 tasks
dcalhoun
added a commit
that referenced
this pull request
Jun 30, 2023
* Release script: Update react-native-editor version to 1.98.0 * Release script: Update with changes from 'npm run core preios' * docs: Add change log entry * Release script: Update react-native-editor version to 1.98.1 * Release script: Update with changes from 'npm run core preios' * fix: Display heading level dropdown icons and labels (#52004) * fix: Heading level dropdown displays active selection A recent refactor for web was only partially applied to the sibling native files. This finishes the application so that the active selection is displayed, passed through via the `value` prop. * fix: Heading level dropdown leverages Icon Without using Icon, the SVG elements rendered without a width, causing layout issues and invisible icons. * docs: Add change log entry * build: Capture Pod changes after trunk merge
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* fix: Heading level dropdown displays active selection A recent refactor for web was only partially applied to the sibling native files. This finishes the application so that the active selection is displayed, passed through via the `value` prop. * fix: Heading level dropdown leverages Icon Without using Icon, the SVG elements rendered without a width, causing layout issues and invisible icons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
What?
Fix the heading level dropdown menu to display the active selection, as well as
icons and labels for all options.
Why?
Fixes #51996. The heading level dropdown was near-impossible to use due to its
broken state.
How?
fix: Heading level dropdown displays active selection
A recent refactor for web was only partially applied to the sibling
native files. This finishes the application so that the active selection
is displayed, passed through via the
valueprop.Move HeadinglevelDropdown to its own component #46003
fix: Heading level dropdown leverages Icon
Without using Icon, the SVG elements rendered without a width, causing
layout issues and invisible icons.
Testing Instructions
H2icon).Testing Instructions for Keyboard
n/a
Screenshots or screencast
See #51996.