Footnotes: show in inserter and placeholder #52445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: +1.89 kB (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
bph
added
the
Backport to WP 6.7 Beta/RC
|
Flaky tests detected in 3948272. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5508876082
|
There was a problem hiding this comment.
Nice idea! I think it's important the Footnotes block can be re-added via the inserter.
I noticed a spacing issue caused by using the Placeholder component without a wrapping div, so left a comment. Also, I noticed that there's quite a bit of a space in the placeholder at the moment. To fill in that space, would it be worth using the icon + heading as in the Table of Contents block for consistency, and add more descriptive text to explain how the Footnotes block works? I suppose the Table of Contents block is probably a good block to compare it to since they both work in a fairly similar way (auto populated by content elsewhere in the document).
Comment on lines
21
to
23
| <Placeholder { ...blockProps }> | ||
| { __( 'No footnotes yet.' ) } | ||
| </Placeholder> |
There was a problem hiding this comment.
I think the Placeholder component might need to be wrapped in a div element, otherwise the component's margin styles overrides a theme's layout styles, causing the placeholder to be rendered flush against other blocks. For example, here the placeholder state is right next to the adjacent paragraph block:
As an example, the Table of Contents block has a wrapper div for its placeholder state, so it has a little more breathing room:
Just an idea, but would something like |
priethor
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Works as expected and can only be added once per post. Thanks for the nice little improvement, Ella!
Just an idea, but would something like
Footnotes found in blocks within this document will be displayed here.work?
I agree with this suggestion, too.
Although I'd recommend addressing the feedback from @andrewserong before merging, I'm giving this a ✅ in case it's not possible before the soft string freeze in 6.3 Beta 4 tomorrow and we need to polish afterwards.
|
Thanks for the feedback, @andrewserong and @priethor! I agree with your suggestions and just committed 3948272. 
|
mcsf
changed the title
tellthemachines
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Footnotes: show in inserter and placehold * Fix placeholder block membrane; fix copy; add icon, label --------- Co-authored-by: Miguel Fonseca <[email protected]>
|
I just cherry-picked this PR to the update/beta-4-second-round branch to get it included in the next release: c98e64d |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
added a commit
that referenced
this pull request
Jul 11, 2023
* Post and Comment Template blocks: Change render_block_context priority to 1 (#52364) * Footnotes: fix lingering format boundary attr (#52439) * Footnotes: Fix incorrect anchor position in Firefox (#52425) * Scope CSS rules for the wp admin reset to js support only. (#52376) * Fix: Patterns & template parts: remove "apply globally" option from block settings (#52160) * Advanced styles panel: add an early return * Update index.js * Minor styling changes * Use array of features --------- Co-authored-by: George Mamadashvili <[email protected]> * make the body of the editor minimmum viewport height so that smaller contents maintain clickability (#52406) * Patterns: Add renaming, duplication, and deletion options (#52270) * Patterns: Update manage pattern links to go to site editor if available (#52403) * [Patterns] Separate sync status into a filter control (#52303) Co-authored-by: Saxon Fletcher <[email protected]> Co-authored-by: Glen Davies <[email protected]> * Patterns: Add missing decoding entities processing in Patterns and Template/Parts pages (#52449) * Fix document title icon appearance (#52424) * Quote block: Add transform to paragraph (#51809) * Add ungroup transform as transform to p * Lint * Update test and snapshot. --------- Co-authored-by: Juan Aldasoro <[email protected]> * remove sidebar group descriptions (#52453) * Patterns: alternative grid layout to improve keyboard accessibility (#52357) * add sync tooltip (#52458) * Patterns: Update section heading levels (#52273) * Ensure that the unsaved title is not persisted when reopening the modal (#52473) * Iframe: avoid asset parsing & fix script localisation (#52405) * Iframe: avoid asset parsing & fix script localisation * Add e2e test for script localisation * Update descriptions (#52468) * Footnotes: show in inserter and placehold (#52445) * Footnotes: show in inserter and placehold * Fix placeholder block membrane; fix copy; add icon, label --------- Co-authored-by: Miguel Fonseca <[email protected]> * Fix: Focus loss on navigation link label editing on Firefox. (#52428) * Update tooltip (#52465) * Refactor, document, and fix image block deprecations (#52081) * Refactor, document, and fix image block deprecations * Fix v5 attributes & supports * Fix v1 & v2 deprecation tests * Rename deprecated test descriptions * Respect custom aspect ratio (#52286) * add image width and height via css inline style, update width and height attrs to be string * keep width and height as attributes too, keep the attributes as numbers * updates image fixtures * RichText/Footnotes: make getRichTextValues work with InnerBlocks.Content (#52241) * RichText/Footnotes: make getRichTextValues work with InnerBlocks.Content --------- Co-authored-by: Miguel Fonseca <[email protected]> * Footnotes: save numbering through the entity provider (#52423) * Footnotes: save numbering through the entity provider * Add sup so no styling is needed at all * Migrate old format * Restore old styles, fix nested attribute queries * Fix anchor selection * Migrate markup in entity provider instead * Fix tests * Fix typo * Fix comment --------- Co-authored-by: Miguel Fonseca <[email protected]> * Revert "Post editor: Require confirmation before removing Footnotes (#52277)" (#52486) This reverts commit e6426ea. * List block: Fix selected type option (#52472) * Library - make pattern title clickable (#51898) * Use button inside title * Remove href * Preserve roving tab index * Fix link colors to match trunk $gray-600 * Remove redundant var * Amend colors as per review * remove old files again --------- Co-authored-by: scruffian <[email protected]> * remove status icon (#52457) * Rename block theme activation nonce variable. (#52398) --------- Co-authored-by: Bernie Reiter <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Andrea Fercia <[email protected]> Co-authored-by: Carolina Nymark <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Aaron Robertshaw <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Saxon Fletcher <[email protected]> Co-authored-by: Glen Davies <[email protected]> Co-authored-by: James Koster <[email protected]> Co-authored-by: Rich Tabor <[email protected]> Co-authored-by: Juan Aldasoro <[email protected]> Co-authored-by: Miguel Fonseca <[email protected]> Co-authored-by: Jorge Costa <[email protected]> Co-authored-by: Alex Lende <[email protected]> Co-authored-by: Héctor <[email protected]> Co-authored-by: Petter Walbø Johnsgård <[email protected]> Co-authored-by: Dave Smith <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: Peter Wilson <[email protected]>
12 tasks
|
Hmm, looks like this didn't make it into 16.2 😕 How bad do we want it in there? Bad enough for a 16.2.1? cc/ @priethor
|
|
I'll go ahead and cherry-pick this to 16.2, and will likely release a 16.2.1 with it included, especially since the PR that reverted requiring confirmation when deleting the Footnotes block did make it into 16.2.0. |
ockham
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Footnotes: show in inserter and placehold * Fix placeholder block membrane; fix copy; add icon, label --------- Co-authored-by: Miguel Fonseca <[email protected]>
Yes, please. This one slipped through the cracks and should be included 🙏 |
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #52277. Since removing the footnotes block is allowed, we should make it easier to re-insert it. Come to think of it, it's probably ok to show it in the inserter anyway. It's good for discoverability. We just show a placeholder until anchors are inserted into the content.
The placeholder text could probably be refined (maybe explaining how to insert anchors), but it's a start.
Why?
As explained above: easier to re-insert and discoverability.
How?
Testing Instructions
Insert the footnotes block through the inserter.
Testing Instructions for Keyboard
Screenshots or screencast