-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Typography text-orientation (Upright and mixed letters) #52624
Conversation
Size Change: +783 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Flaky tests detected in f433ffb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6556742112
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
packages/block-editor/src/components/writing-mode-control/index.js
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This pull request changed or added PHP files in previous commits, but none have been detected in the latest commit. Thank you! ❤️ |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I'm sorry, perhaps we can widen the ping range for some help? For what it's worth, I really appreciate you running with this 🙏
It's part of the GIF, yes. In the start, I add the vertical option an set the vertical text. Right after I click the This toggling off is not just about hiding the design tool, but also about resetting it. Note here in this example, I have letter spacing set to 20px, and when I untoggle the letter spacing control, the spacing is also reset: |
There's some overlap with the inheritance explorations being explored here: #49278 (comment) |
I am trying to set both
Update: I removed the code that caused this, but it means that deselecting the panel only resets one of the controls, the writing mode. |
packages/block-editor/src/components/text-orientation-control/index.js
Outdated
Show resolved
Hide resolved
Please, if possible, I need more straight forward and clear communication. |
I believe I have removed what can be safely removed, and not too much. But if this is not what you expected, then we can revert it. |
Since we are at 6.4 RC1 this needs to be updated for 6.5 instead. I have been thinking about the theme.json options. By removing it, theme developers can no longer set defaults.
Now we can only use:
|
I have moved this to 6.5 in light of your comment above! Let me know if that's incorrect. |
@WordPress/block-themers Hi, I need help with moving this issue forward and deciding how we, as theme developers, want the text orientation options to work in theme.json. Which styles need to be available?
|
You're right this is quite a severe shortcoming. I think we should add |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @apeatling, @tao-s, @burnuser. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
The underlying problem with having both as block supports still remains, the control in the editor did not work well. 🤔 |
Because of the time passed, it is probably easiest to just start over with this... |
I think we can have both block supports but keep the current control - one control that changes two properties... |
This is ready for another code review. Both types of theme.json settings work. As for the result when the settings are used, I still find it confusing that the text is also changed to be read right to left. |
Thanks for continuing to push this forward. I think it's very close. Some things I am seeing:
I think if we can get these things sorted we can merge. BTW I tried to rebase this but it was difficult because there are so many commits. I would just squash them before I rebase, is it OK to do that? |
Yes! |
Rebasing this was beyond me, but I did manage to squash it into a new branch if we want to switch to that: #59901 |
What?
Adds a text-orientation typography block support, to be combined with the writing mode block support.
Adds support for text-orientation to paragraph blocks.
Follow up to #50822
Closes #50319
Testing Instructions
This setting is disabled by default and can be enabled for themes that include theme.json.
writingMode: true
andtextOrientation: true
.Screenshots or screencast
text-orientation.mp4