Try: reduce number of WP_Theme_JSON instances
#53357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simulates that blocks do not invalidate the cache. It is a hack to get a prototype working and gauge the impact on performance. The final code should delay sanitization to later stages.
oandregal
changed the title
WP_Theme_JSON instances
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/class-wp-theme-json-gutenberg.php ❔ lib/class-wp-theme-json-resolver-gutenberg.php |
|
Something like this would be a little improvement for both classic and block themes (-2ms). 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT PR TO SEE THE IMPACT ON PERFORMANCE TESTS. NOT TO MERGE.
Related #45171
What?
Reduce the number of
WP_Theme_JSONinstances.Why?
Faster is better.
How?
This PR tries to avoid cache invalidation for some of the existing
theme.jsoncaches. By doing so, the number of instances ofWP_Theme_JSONgo from 30 to 18, reducing the number of processes and the time they take.Testing Instructions
See the impact of the performance tests. TBD.