Interactivity API: add short-cirtuit to useSignalEffect
#53358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisherranz
added
[Type] Bug
luisherranz
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad and
ajitbohra
as code owners
|
Size Change: +25 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
DAreRodz
reviewed
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a short circuit to our version of
useSignalEffectto avoid infinite loops.Why?
Because the original
@preact/signalslibrary only short-circuits synchronous infinite loops, anduseSignalEffectis asynchronous because it needs to wait until the DOM has been update to execute the callback.How?
By turning the delayed notification mechanism (
afterNextFrame) into a promise, and ignoring all the notifications that happen before the callback has been finally executed.I also added the original
setTimeout(apart from therequestAnimationFrame) because apparently therequestAnimationFramemay not be triggered if users are in another tab.