Quality: remove unnecessary as prop from SiteHub component
#53372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
draganescu
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem mentioned in this comment
What?
This PR removes unintended
asattributes applied to theSiteHubcomponent.Why?
As I understand it, the
asprop is used to control what element/component a certain component is to be rendered as. However, since theSiteHubcomponent was originally rendered asmotion.divand theasproperty is not used internally either, removing it should not be a problem.How?
Removed
asprop.Testing Instructions
There should be no effect on the Site Editor, but confirm that animations still work as before when switching between view and edit modes, or in the distraction-free mode added in #51173.