UnsavedChangesWarning: Don't return a function from 'mapSelect' #53672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: -4 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
I've going to merge this. It's a straightforward refactoring, and the feature is covered by e2e tests ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Discovered while working on #53666.
PR refactors the
UnsavedChangesWarningcomponent to avoid returning a callback frommapSelect. Instead, use the__experimentalGetDirtyEntityRecordsselector directly.It also fixes ESLint warnings for the
useEffecthook. The changes are in separate commit - 8ea99fb.Why?
The
mapSelectreturns a new callback value on every call and this can lead to unnecessary rerenders.Testing Instructions
Screenshots or screencast